On 2024/3/18 9:28, Christoph Hellwig wrote: > The patch looks good to me: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > But maybe I'd reword the commit message a bit, i.e.: > > xfs: make the seq argument to xfs_bmapi_convert_delalloc optional > > Allow callers to pass a NULLL seq argument if they don't care about > the fork sequence number. > Okay, that's clearer. Thanks, Yi.