On Mon, Mar 11, 2024 at 08:48:29AM -0700, Darrick J. Wong wrote: > This change should be a separate patch with its own justification. > Which is, AFAICT, something along the lines of: > > "Unsharing and zeroing can only happen within EOF, so there is never a > need to perform posteof pagecache truncation if write begin fails." Agreed. > > Signed-off-by: Zhang Yi <yi.zhang@xxxxxxxxxx> > > Doesn't this patch fix a bug in ext4? Only with the not yet merged ext4 conversion to iomap for buffered I/O, which is not merged yet.