On Thu, Mar 07, 2024 at 07:31:35PM +0200, Amir Goldstein wrote: > On Thu, Mar 7, 2024 at 6:13 PM Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > > > > On Thu, 7 Mar 2024 at 15:09, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > > > > > > On Thu, 7 Mar 2024 at 14:11, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > > > > > P.S. A guard for ovl_inode_lock() would have been useful in this patch set, > > > > but it's up to you if you want to define one and use it. > > > > I like the concept of guards, though documentation and examples are > > lacking and the API is not trivial to understand at first sight. > > > > For overlayfs I'd start with ovl_override_creds(), since that is used > > much more extensively than ovl_inode_lock(). > > > > OK. let's wait for this to land first: > https://lore.kernel.org/linux-unionfs/20240216051640.197378-1-vinicius.gomes@xxxxxxxxx/ > > As I wrote in the review of v2, > I'd rather that Christian will review and pick up the non-overlayfs bits, > which head suggested and only after that will I review the overlayfs > patch. On it. Had been on my queue but didn't get around to it. I wanted to play with this a bit.
