On 3/8/24 10:15 AM, John Garry wrote: > On 08/03/2024 17:05, Jens Axboe wrote: >>> And the callers can hardcode rw_type? >> Yep, basically making the change identical to the aio one. Not sure why >> you did it differently in those two spots. > > In the aio code, rw_type was readily available. For io_uring it was > not, and I chose to derive from something locally available. But > that's a bit awkward and is not good for performance, so I'll follow > your suggestion. It's literally just one caller back, it's not like you had to look hard to spot this. Don't take lazy shortcuts - it's not very confidence inspiring if this is the level of attention to detail that went into this patchset. -- Jens Axboe
