Re: [PATCH v5 24/37] rust: Add a rust helper for krealloc()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Suren Baghdasaryan <surenb@xxxxxxxxxx>
Subject: Re: [PATCH v5 24/37] rust: Add a rust helper for krealloc()
From: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx>
Date: Fri, 8 Mar 2024 16:23:30 +0100
Cc: akpm@xxxxxxxxxxxxxxxxxxxx, kent.overstreet@xxxxxxxxx, mhocko@xxxxxxxx, vbabka@xxxxxxx, hannes@xxxxxxxxxxx, roman.gushchin@xxxxxxxxx, mgorman@xxxxxxx, dave@xxxxxxxxxxxx, willy@xxxxxxxxxxxxx, liam.howlett@xxxxxxxxxx, penguin-kernel@xxxxxxxxxxxxxxxxxxx, corbet@xxxxxxx, void@xxxxxxxxxxxxx, peterz@xxxxxxxxxxxxx, juri.lelli@xxxxxxxxxx, catalin.marinas@xxxxxxx, will@xxxxxxxxxx, arnd@xxxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, peterx@xxxxxxxxxx, david@xxxxxxxxxx, axboe@xxxxxxxxx, mcgrof@xxxxxxxxxx, masahiroy@xxxxxxxxxx, nathan@xxxxxxxxxx, dennis@xxxxxxxxxx, jhubbard@xxxxxxxxxx, tj@xxxxxxxxxx, muchun.song@xxxxxxxxx, rppt@xxxxxxxxxx, paulmck@xxxxxxxxxx, pasha.tatashin@xxxxxxxxxx, yosryahmed@xxxxxxxxxx, yuzhao@xxxxxxxxxx, dhowells@xxxxxxxxxx, hughd@xxxxxxxxxx, andreyknvl@xxxxxxxxx, keescook@xxxxxxxxxxxx, ndesaulniers@xxxxxxxxxx, vvvvvv@xxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, ebiggers@xxxxxxxxxx, ytcoode@xxxxxxxxx, vincent.guittot@xxxxxxxxxx, dietmar.eggemann@xxxxxxx, rostedt@xxxxxxxxxxx, bsegall@xxxxxxxxxx, bristot@xxxxxxxxxx, vschneid@xxxxxxxxxx, cl@xxxxxxxxx, penberg@xxxxxxxxxx, iamjoonsoo.kim@xxxxxxx, 42.hyeyoo@xxxxxxxxx, glider@xxxxxxxxxx, elver@xxxxxxxxxx, dvyukov@xxxxxxxxxx, shakeelb@xxxxxxxxxx, songmuchun@xxxxxxxxxxxxx, jbaron@xxxxxxxxxx, aliceryhl@xxxxxxxxxx, rientjes@xxxxxxxxxx, minchan@xxxxxxxxxx, kaleshsingh@xxxxxxxxxx, kernel-team@xxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, iommu@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-modules@xxxxxxxxxxxxxxx, kasan-dev@xxxxxxxxxxxxxxxx, cgroups@xxxxxxxxxxxxxxx, Miguel Ojeda <ojeda@xxxxxxxxxx>, Alex Gaynor <alex.gaynor@xxxxxxxxx>, Wedson Almeida Filho <wedsonaf@xxxxxxxxx>, Boqun Feng <boqun.feng@xxxxxxxxx>, Gary Guo <gary@xxxxxxxxxxx>, Björn Roy Baron <bjorn3_gh@xxxxxxxxxxxxxx>, Benno Lossin <benno.lossin@xxxxxxxxx>, Andreas Hindborg <a.hindborg@xxxxxxxxxxx>, rust-for-linux@xxxxxxxxxxxxxxx
In-reply-to: <20240306182440.2003814-25-surenb@google.com>

On Wed, Mar 6, 2024 at 7:26 PM Suren Baghdasaryan <surenb@xxxxxxxxxx> wrote:
>
> +void * __must_check rust_helper_krealloc(const void *objp, size_t new_size,
> +                                        gfp_t flags) __realloc_size(2)

The `__realloc_size(2)` should be placed earlier, i.e. this triggers:

rust/helpers.c:162:20: error: GCC does not allow '__alloc_size__'
attribute in this position on a function definition [-Wgcc-compat]

With that fixed:

Acked-by: Miguel Ojeda <ojeda@xxxxxxxxxx>

Cheers,
Miguel

References:
- [PATCH v5 00/37] Memory allocation profiling
  - From: Suren Baghdasaryan
- [PATCH v5 24/37] rust: Add a rust helper for krealloc()
  - From: Suren Baghdasaryan

Prev by Date: Re: [syzbot] [reiserfs?] general protection fault in direct2indirect
Next by Date: Re: [PATCH v5 03/10] fs: Initial atomic write support
Previous by thread: [PATCH v5 24/37] rust: Add a rust helper for krealloc()
Next by thread: [PATCH v5 25/37] mm/slab: enable slab allocation tagging for kmalloc and friends
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]