Re: [PATCH] tmpfs: don't interrupt fallocate with EINTR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Thu, Mar 07, 2024 at 11:45:59AM +0100, Christian Brauner wrote:
> Right now fallocate() is restartable. You could get EINTR and then
> retry. Changing this to fatal_signal_pending() would mean that this
> property is lost. The task will have to be wiped.

People made much the same argument when I removed the nfs 'intr'
mount option.  It hasn't actually caused any issues that I've seen.

> If this is only done for the sake of the OOM killer then we can probably
> try and change it. But then we'd need to also reflect that on the
> manpage.

It's part of POSIX, I wouldn't remove the manpage.  I think it's a QoI
issue; we should only check for fatal signals.

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux