On Tue, 5 Mar 2024, Christian Brauner wrote: > On Mon, Mar 04, 2024 at 07:43:39PM +0100, Mikulas Patocka wrote: > > > > Index: linux-2.6/mm/shmem.c > > =================================================================== > > --- linux-2.6.orig/mm/shmem.c 2024-01-18 19:18:31.000000000 +0100 > > +++ linux-2.6/mm/shmem.c 2024-03-04 19:05:25.000000000 +0100 > > @@ -3143,7 +3143,7 @@ static long shmem_fallocate(struct file > > * Good, the fallocate(2) manpage permits EINTR: we may have > > * been interrupted because we are using up too much memory. > > */ > > - if (signal_pending(current)) > > + if (fatal_signal_pending(current)) > > I think that's likely wrong and probably would cause regressions as > there may be users relying on this? ext4 fallocate doesn't return -EINTR. So, userspace code can't rely on it. Mikulas
