On Sat, Sep 12, 2009 at 02:29:30AM +0800, Christoph Hellwig wrote: > On Fri, Sep 11, 2009 at 06:50:31PM +0800, Wu Fengguang wrote: > > Currently all simple_attr.set handlers return 0 on success and negative > > codes on error. Fix simple_attr_write() to return these error codes. > > Looks good to me assuming you actually audited all the implementations > to do the right thing. Yes I checked all DEFINE_SIMPLE_ATTRIBUTE users. All the _set() handlers returns 0 for success and negative error code for failure. Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html