On Fri, Sep 11 2009, Christoph Hellwig wrote: > On Fri, Sep 11, 2009 at 01:50:30PM +0200, Jens Axboe wrote: > > We do this automatically in get_sb_bdev() from the set_bdev_super() > > callback. Filesystems that have their own private backing_dev_info > > must assign that in ->fill_super(). > > > > Note that ->s_bdi assignment is required for proper writeback! > > Looks good to me. Can we get rid of BDI_CAP_NO_WRITEBACK with this by > simply not assigning a bdi? Good question, I was indeed looking for an sb equivalent of that bdi flag. And now ->s_bdi being set or not is indeed that. Some of our generated writeback originates at the bdi level though, so we may or may not have the sb. From a quick look at fs-writeback.c, it looks feasible though. I'll try. Can I take that as an acked-by? -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
