> On Mar 1, 2024, at 16:09, Giuseppe Scrivano <gscrivan@xxxxxxxxxx> wrote: > > Muchun Song <muchun.song@xxxxxxxxx> writes: > >>> On Feb 29, 2024, at 23:24, Giuseppe Scrivano <gscrivan@xxxxxxxxxx> wrote: >>> >>> pass down the idmapped mount information to the different helper >>> functions. >>> >>> Differently, hugetlb_file_setup() will continue to not have any >>> mapping since it is only used from contexts where idmapped mounts are >>> not used. >> >> Sorry, could you explain more why you want this changes? What's the >> intention? > > we are adding user namespace support to Kubernetes to run each > pod (a group of containers) without overlapping IDs. We need idmapped > mounts for any mount shared among multiple pods. > > It was reported both for crun and containerd: > > - https://github.com/containers/crun/issues/1380 > - https://github.com/containerd/containerd/issues/9585 It is helpful and really should go into commit log to explain why it is necessary (those information will useful for others). The changes are straightforward, but I am not familiar with Idmappings (I am not sure if there are more things to be considered). Thanks. > > Regards, > Giuseppe
