On Fri, 2009-09-11 at 01:26 -0400, Eric Paris wrote: > fanotify sends event notification to userspace when userspace reads from the > fanotify socket. This patch implements the operations that happen at read > time. These include opening the file descriptor to the original object and > then filling the userspace buffer. The fd should be pollable to indicate when > it has data present and it should return how much data it has to send when the > FIONREAD ioctl is checked. > This patch has one checkpatch error, could you fix that? .. Also your whole series has several very long lines over 80 characters , you might want to consider trimming those down to 80 or less.. If you run these patches through checkpatch you should output like the following denoting the issues, ERROR: "(foo*)" should be "(foo *)" #381: FILE: include/linux/fanotify.h:84: + (struct fanotify_event_metadata*)(((char *)(meta)) + \ WARNING: line over 80 characters #384: FILE: include/linux/fanotify.h:87: +#define FAN_EVENT_OK(meta, len) ((long)(len) >= (long)FAN_EVENT_METADATA_LEN && \ Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
