On Thu, 2009-09-10 at 22:40 +0200, Christoph Hellwig wrote: > On Thu, Sep 10, 2009 at 04:38:40PM -0400, Trond Myklebust wrote: > > > return vfs_fsync_range(file, file->f_path.dentry, pos, > > > - pos + count - 1, 1); > > > + pos + count - 1, > > > + (file->f_flags & O_SYNC) ? 1 : 0); > > > } > > > EXPORT_SYMBOL(generic_write_sync); > > > > > Shouldn't this be testing for > > > > file->f_flags & __O_SYNC > > > > ? > > Doesn't matter, we check early in the open path that __O_SYNC is only > set together with O_SYNC. Right, but (file->f_flags & O_SYNC) will be non-zero even if only the O_DSYNC flag is set. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
