On Fri, Feb 23, 2024 at 02:16:15PM +0100, Thomas Weißschuh wrote: > On 2023-12-28 05:22:56-0800, Luis Chamberlain wrote: > > On Tue, Dec 26, 2023 at 01:32:42PM +0100, Thomas Weißschuh wrote: > > > The set_ownership callback is not supposed to modify the ctl_table. > > > Enforce this expectation via the typesystem. > > > > > > The patch was created with the following coccinelle script: > > > > > > virtual patch > > > virtual context > > > virtual report > > > > If you remove this virtual stuff and mention how we verify manually > > through the build how users do not exits which rely on modifying the the > > table I thinkt these two patches are ready, thanks for doing this in > > Coccinelle it helps me review this faster! > > Actually the 'table' parameter is never even used. Oh wow. > Do you prefer to drop it completely? Absolutely. Luis