On Wed, Sep 09, 2009 at 10:52:16AM -0500, James Bottomley wrote: > xfs_buf.c includes what is essentially a hand rolled version of > blk_rq_map_kern(). In order to work properly with the vmalloc buffers > that xfs uses, this hand rolled routine must also implement the flushing > API for vmap/vmalloc areas. It's not really a handcrafted version of blk_rq_map_kern because it can add discontinuous into a single bio. The patches look fine to (not pretty but fine :)), and I'll make sure they get added once those two helpers made it, probably augmented by a comment explaining what's going on here. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html