Re: [PATCH v4 09/11] scsi: scsi_debug: Atomic write support

To: Ojaswin Mujoo <ojaswin@xxxxxxxxxxxxx>
Subject: Re: [PATCH v4 09/11] scsi: scsi_debug: Atomic write support
From: John Garry <john.g.garry@xxxxxxxxxx>
Date: Tue, 20 Feb 2024 09:01:14 +0000
Cc: axboe@xxxxxxxxx, kbusch@xxxxxxxxxx, hch@xxxxxx, sagi@xxxxxxxxxxx, jejb@xxxxxxxxxxxxx, martin.petersen@xxxxxxxxxx, djwong@xxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, brauner@xxxxxxxxxx, dchinner@xxxxxxxxxx, jack@xxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, tytso@xxxxxxx, jbongio@xxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-aio@xxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, io-uring@xxxxxxxxxxxxxxx, nilay@xxxxxxxxxxxxx, ritesh.list@xxxxxxxxx
In-reply-to: <ZdRQ8mPGRVidvjQI@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com>
Organization: Oracle Corporation
User-agent: Mozilla Thunderbird

On 20/02/2024 07:12, Ojaswin Mujoo wrote:

+MODULE_PARM_DESC(atomic_write, "enable ATOMIC WRITE support, support WRITE ATOMIC(16) (def=1)");

Hi John,

The default value here seems to be 0 and not 1. Got me a bit confused
while testing 🙂


I can fix that MODULE_PARM_DESC() text.

I don't think that many disks support atomic writes, so I was leavingthis disabled by default.


Thanks,
John

References:
- [PATCH v4 00/11] block atomic writes
  - From: John Garry
- [PATCH v4 09/11] scsi: scsi_debug: Atomic write support
  - From: John Garry
- Re: [PATCH v4 09/11] scsi: scsi_debug: Atomic write support
  - From: Ojaswin Mujoo