On Fri, Feb 16, 2024 at 08:13:25AM +0100, Christoph Hellwig wrote: > On Thu, Feb 15, 2024 at 12:47:39PM -0800, Bart Van Assche wrote: > > The following patch accidentally removed the code for delivering > > completions for cancelled reads and writes to user space: "[PATCH 04/33] > > aio: remove retry-based AIO" > > (https://lore.kernel.org/all/1363883754-27966-5-git-send-email-koverstreet@xxxxxxxxxx/) > > Umm, that was more than 10 years ago. What code do you have that > is this old, and only noticed that it needs the completions now? > > I'd much prefer your older patch to simply always fail the cancelations. Hm, if no one noticed for that long then I agree that we should probably try and get rid of this.