On Tue 13-02-24 16:37:25, Chuck Lever wrote: > From: Chuck Lever <chuck.lever@xxxxxxxxxx> > > Most of instances of "so_ctx" were renamed before the simple offset > work was merged, but there were a few that were missed. > > Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx> Looks good. Feel free to add: Reviewed-by: Jan Kara <jack@xxxxxxx> Honza > --- > fs/libfs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/libfs.c b/fs/libfs.c > index eec6031b0155..bfbe1a8c5d2d 100644 > --- a/fs/libfs.c > +++ b/fs/libfs.c > @@ -271,7 +271,7 @@ void simple_offset_init(struct offset_ctx *octx) > * @octx: directory offset ctx to be updated > * @dentry: new dentry being added > * > - * Returns zero on success. @so_ctx and the dentry offset are updated. > + * Returns zero on success. @octx and the dentry's offset are updated. > * Otherwise, a negative errno value is returned. > */ > int simple_offset_add(struct offset_ctx *octx, struct dentry *dentry) > @@ -430,8 +430,8 @@ static bool offset_dir_emit(struct dir_context *ctx, struct dentry *dentry) > > static void *offset_iterate_dir(struct inode *inode, struct dir_context *ctx) > { > - struct offset_ctx *so_ctx = inode->i_op->get_offset_ctx(inode); > - XA_STATE(xas, &so_ctx->xa, ctx->pos); > + struct offset_ctx *octx = inode->i_op->get_offset_ctx(inode); > + XA_STATE(xas, &octx->xa, ctx->pos); > struct dentry *dentry; > > while (true) { > > -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR