On 2/13/24 6:49 AM, Jan Kara wrote: > On Fri 09-02-24 13:43:09, Eric Sandeen wrote: >> Convert the UDF filesystem to the new mount API. >> >> UDF is slightly unique in that it always preserves prior mount >> options across a remount, so that's handled by udf_init_options(). > Well, ext4 does this as well AFAICT. See e.g. ext4_apply_options() and how > it does: > > sbi->s_mount_opt &= ~ctx->mask_s_mount_opt; > sbi->s_mount_opt |= ctx->vals_s_mount_opt; > sbi->s_mount_opt2 &= ~ctx->mask_s_mount_opt2; > sbi->s_mount_opt2 |= ctx->vals_s_mount_opt2; > sb->s_flags &= ~ctx->mask_s_flags; > sb->s_flags |= ctx->vals_s_flags; > > so it really modifies the current superblock state, not overwrites it. > >> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> >> --- >> >> Tested by running through xfstests, as well as some targeted testing of >> remount behavior. >> >> NB: I did not convert i.e any udf_err() to errorf(fc, ) because the former >> does some nice formatting, not sure how or if you'd like to handle that, Jan? > Which one would you like to convert? I didn't find any obvious > candidates... Or do you mean the messages in udf_fill_super() when we find > on-disk inconsistencies or similar? I guess we can leave that for later > because propagating 'fc' into all the validation functions will be a lot of > churn. Yup I was thinking about messages in fill_super. I can check w/ dhowells later to see what the expectation is, but I had the hunch that generally any errors encountered during mount should route through those functions now. Happy to leave it for later ;) -Eric
