On 2/9/24 16:40, Gabriel Krisman Bertazi wrote: > Eugen Hristev <eugen.hristev@xxxxxxxxxxxxx> writes: > >> On 2/8/24 20:38, Gabriel Krisman Bertazi wrote: > >>> (untested) >> >> I implemented your suggestion, but any idea about testing ? I ran smoke on xfstests >> and it appears to be fine, but maybe some specific test case might try the >> different paths here ? > > Other than running the fstests quick group for each affected filesystems > looking for regressions, the way I'd do it is create a few files and > look them up with exact and inexact name matches. While doing that, > observe through bpftrace which functions got called and what they > returned. > > Here, since you are testing the uncached lookup, you want to make sure > to drop the cached version prior to each lookup. > Hello Gabriel, With the changes you suggested, I get these errors now : [ 107.409410] EXT4-fs error (device sda1): ext4_lookup:1816: inode #521217: comm ls: 'CUC' linked to parent dir ls: cannot access '/media/CI_dir/CUC': Structure needs cleaning total 8 drwxr-xr-x 2 root root 4096 Feb 12 11:51 . drwxr-xr-x 4 root root 4096 Feb 12 11:47 .. -????????? ? ? ? ? ? CUC Do you have any idea about what is wrong ? Thanks, Eugen
