Re: [PATCH v5 1/9] rust: types: add `NotThreadSafe`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Miguel Ojeda <ojeda@xxxxxxxxxx>, Alex Gaynor <alex.gaynor@xxxxxxxxx>, Wedson Almeida Filho <wedsonaf@xxxxxxxxx>, Boqun Feng <boqun.feng@xxxxxxxxx>, Gary Guo <gary@xxxxxxxxxxx>, Björn Roy Baron <bjorn3_gh@xxxxxxxxxxxxxx>, Benno Lossin <benno.lossin@xxxxxxxxx>, Andreas Hindborg <a.hindborg@xxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Arve Hjønnevåg <arve@xxxxxxxxxxx>, Todd Kjos <tkjos@xxxxxxxxxxx>, Martijn Coenen <maco@xxxxxxxxxxx>, Joel Fernandes <joel@xxxxxxxxxxxxxxxxx>, Carlos Llamas <cmllamas@xxxxxxxxxx>, Suren Baghdasaryan <surenb@xxxxxxxxxx>
Subject: Re: [PATCH v5 1/9] rust: types: add `NotThreadSafe`
From: Alice Ryhl <aliceryhl@xxxxxxxxxx>
Date: Fri, 9 Feb 2024 12:49:07 +0100
Cc: Dan Williams <dan.j.williams@xxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Daniel Xu <dxu@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, rust-for-linux@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, Trevor Gross <tmgross@xxxxxxxxx>, Martin Rodriguez Reboredo <yakoyoku@xxxxxxxxx>
In-reply-to: <20240209-alice-file-v5-1-a37886783025@google.com>

On Fri, Feb 9, 2024 at 12:18 PM Alice Ryhl <aliceryhl@xxxxxxxxxx> wrote:
> +    types::{NotThreadSafe, ScopeGuard, Opaque},

Oops. This one doesn't pass rustfmt. Embarrassing.

I was hoping that this would be the last version. Maybe Miguel can fix
the ordering here when he takes it? (Assuming I don't need to send a
v6.)

It's supposed to be:
types::{NotThreadSafe, Opaque, ScopeGuard},

There shouldn't be any other issues in this patchset.

Alice

References:
- [PATCH v5 0/9] File abstractions needed by Rust Binder
  - From: Alice Ryhl
- [PATCH v5 1/9] rust: types: add `NotThreadSafe`
  - From: Alice Ryhl

Prev by Date: Re: [PATCH v3 9/9] fuse: allow parallel dio writes with FUSE_DIRECT_IO_ALLOW_MMAP
Next by Date: Re: [PATCH v3 8/9] fuse: introduce inode io modes
Previous by thread: [PATCH v5 1/9] rust: types: add `NotThreadSafe`
Next by thread: [PATCH v5 2/9] rust: task: add `Task::current_raw`
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]