Re: [PATCH v3 2/9] fuse: Create helper function if DIO write needs exclusive lock

[Miklos Szeredi <miklos@xxxxxxxxxx>]

On Thu, 8 Feb 2024 at 18:08, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
> @@ -2468,7 +2493,8 @@ static int fuse_file_mmap(struct file *file, struct vm_area_struct *vma)
>                 return fuse_dax_mmap(file, vma);
>
>         if (ff->open_flags & FOPEN_DIRECT_IO) {
> -               /* Can't provide the coherency needed for MAP_SHARED
> +               /*
> +                * Can't provide the coherency needed for MAP_SHARED
>                  * if FUSE_DIRECT_IO_ALLOW_MMAP isn't set.
>                  */
>                 if ((vma->vm_flags & VM_MAYSHARE) && !fc->direct_io_allow_mmap)

This last hunk seems to belong in the previous patch.

Thanks,
Miklos