On Wed, Feb 07, 2024 at 11:07:26AM -0800, Jakub Kicinski wrote: > On Wed, 7 Feb 2024 10:50:15 -0800 Joe Damato wrote: > > > This !! is unnecessary. Nonzero values shall be "converted" to true. > > > > > > But FWIW, the above is nothing which should be blocking, so: > > "> > > > Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx> > > > > netdev maintainers: Jiri marked this with Reviewed-by, but was this review > > what caused "Changes Requested" to be the status set for this patch set in > > patchwork? > > > > If needed, I'll send a v7 with the changes Jiri suggested and add the > > "Reviewed-by" since the changes are cosmetic, but I wanted to make sure > > this was the reason. > > Yes, I think that's it. OK, thanks for letting me know. I wasn't sure if it was because of the netdev/source_inline which marked 1/4 as "fail" because of the inlines added. Does that need to be changed, as well?
