Re: [PATCH 2/2] fs: remove the inode argument to ->d_real() method

[Amir Goldstein <amir73il@xxxxxxxxx>]

On Fri, Feb 2, 2024 at 3:55 PM Christian Brauner <brauner@xxxxxxxxxx> wrote:
>
> On Fri, Feb 02, 2024 at 02:41:16PM +0200, Amir Goldstein wrote:
> > On Fri, Feb 2, 2024 at 2:19 PM Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
> > >
> > > On Fri, 2 Feb 2024 at 12:01, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
> > >
> > > > diff --git a/Documentation/filesystems/locking.rst b/Documentation/filesystems/locking.rst
> > > > index d5bf4b6b7509..453039a2e49b 100644
> > > > --- a/Documentation/filesystems/locking.rst
> > > > +++ b/Documentation/filesystems/locking.rst
> > > > @@ -29,7 +29,7 @@ prototypes::
> > > >         char *(*d_dname)((struct dentry *dentry, char *buffer, int buflen);
> > > >         struct vfsmount *(*d_automount)(struct path *path);
> > > >         int (*d_manage)(const struct path *, bool);
> > > > -       struct dentry *(*d_real)(struct dentry *, const struct inode *);
> > > > +       struct dentry *(*d_real)(struct dentry *, int type);
> > >
> > > Why not use the specific enum type for the argument?
> >
> > No reason, we can do enum d_real_type.
>
> Fwiw, I'm happy to just change this. No need to resend as far as I'm concerned.

FWIW, I'd be happy if you do that :)
Note to move enum d_real_type definition above dentry_operations.

Please add Stefan's Tested-by to both patches.

Thanks,
Amir.