Re: [PATCH-next] epoll: Remove ep_scan_ready_list() in comments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue 06-02-24 09:43:53, Huang Xiaojia wrote:
> Since commit 443f1a042233 ("lift the calls of ep_send_events_proc()
> into the callers"), ep_scan_ready_list() has been removed.
> But there are still several in comments. All of them should
> be replaced with other caller functions.
> 
> Signed-off-by: Huang Xiaojia <huangxiaojia2@xxxxxxxxxx>

Not really eventpoll expert but from a cursory look this looks fine to me.
Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

One nit below:


> --- a/fs/eventpoll.c
> +++ b/fs/eventpoll.c
> @@ -206,7 +206,7 @@ struct eventpoll {
>  	 */
>  	struct epitem *ovflist;
>  
> -	/* wakeup_source used when ep_scan_ready_list is running */
> +	/* wakeup_source used when ep_send_events or __ep_eventpoll_poll is running */

Please wrap this comment like:

	/*
	 * wakeup_source - used when ep_send_events or __ep_eventpoll_poll is
	 * running
	 */

									Honza
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux