On Fri, Feb 2, 2024 at 5:55 PM Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > > On Thu, 1 Feb 2024 at 00:09, Bernd Schubert <bschubert@xxxxxxx> wrote: > > > > From: Amir Goldstein <amir73il@xxxxxxxxx> > > > > In preparation for inode io modes, a server open response could fail > > due to conflicting inode io modes. > > > > Allow returning an error from fuse_finish_open() and handle the error in > > the callers. fuse_dir_open() can now call fuse_sync_release(), so handle > > the isdir case correctly. > > Another question: will fuse_finish_open() fail for any reason other > than due to an interrupted wait? > Yes. Definitely. With fuse passthrough. Wait for parallel dio is Benrd's share of the patch set. My interest was always to deny cached open and passthrough open of the same inode and passthrough file open to a conflicting backing file as we have agreed [1]. See this passthough open commit for example: https://github.com/amir73il/linux/commit/9422b02931ca4be5471230645a2b4a6723f99d0e I will also split fuse_finish_dir_open() as you suggested. Thanks, Amir. [1] https://lore.kernel.org/linux-fsdevel/CAJfpegsoHtp_VthZRGfcoBREZ0pveb4wYYiKVEnCxaTgGEaeWw@xxxxxxxxxxxxxx/
