On Mon, Jan 29, 2024 at 03:09:29PM +0800, Kefeng Wang wrote: > Commit 2916ecc0f9d4 ("mm/migrate: new migrate mode MIGRATE_SYNC_NO_COPY") > introduce a new MIGRATE_SYNC_NO_COPY mode to allow to offload the copy to > a device DMA engine, which is only used __migrate_device_pages() to decide > whether or not copy the old page, and the MIGRATE_SYNC_NO_COPY mode only > set in hmm, as the MIGRATE_SYNC_NO_COPY set is removed by previous cleanup, > it seems that we could remove the unnecessary MIGRATE_SYNC_NO_COPY. Ah! I didn't understand the point of what you were doing in the previous patch. Now it makes a lot more sense. This is a big improvement, thanks!