On Thu 01-02-24 17:34:26, Kunwu Chan wrote:
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
>
> Signed-off-by: Kunwu Chan <chentao@xxxxxxxxxx>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
Honza
> ---
> fs/mbcache.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/fs/mbcache.c b/fs/mbcache.c
> index 82aa7a35db26..fe2624e17253 100644
> --- a/fs/mbcache.c
> +++ b/fs/mbcache.c
> @@ -426,9 +426,8 @@ EXPORT_SYMBOL(mb_cache_destroy);
>
> static int __init mbcache_init(void)
> {
> - mb_entry_cache = kmem_cache_create("mbcache",
> - sizeof(struct mb_cache_entry), 0,
> - SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD, NULL);
> + mb_entry_cache = KMEM_CACHE(mb_cache_entry,
> + SLAB_RECLAIM_ACCOUNT | SLAB_MEM_SPREAD);
> if (!mb_entry_cache)
> return -ENOMEM;
> return 0;
> --
> 2.39.2
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
