On Wed, Jan 31, 2024 at 9:23 PM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > > On Wed, Jan 31, 2024 at 06:59:12PM +0800, zhaoyang.huang wrote: > > change of v6: replace the macro of bio_add_xxx by submit_bio which > > iterating the bio_vec before launching bio to block layer > > Still wrong. I did some research on bio operations in the system and state my understanding here. I would like to have you review it and give me more details of the fault. thanks 1. REQ_OP_ZONE_xxx a. These operations are from driver/block layer/fs where we can keep driver/block layer using the legacy submit_bio by not including act_prio.h. b. most of fs's REQ_OP_ZONE_xxx will be handled by blkdev_zone_mgmt which is the same as 'a' c. __submit_zone_reset_cmd within f2fs use no page for REQ_OP_ZONE_RESET 2. other REQ_OP_<none>_READ/WRITE except REQ_OP_ZONE_xxx These operations all comes from driver and block layer as same as 1.a 3. direct_io keep fs/direct-io.c and fs/iomap/direct-io.c using legacy submit_bio 4. metadata, dentry Are these data also file pages? 5. normal REQ_OP_READ/WRITE/SYNC fs choose to use act based submit_bio by including act_ioprio.h in corresponding c file
