Eric Biggers <ebiggers@xxxxxxxxxx> writes: > On Fri, Jan 19, 2024 at 03:47:33PM -0300, Gabriel Krisman Bertazi wrote: >> ovl: Reject mounting case-insensitive filesystems > > Overlayfs doesn't mount filesystems. I think you might mean something like > reject case-insensitive lowerdirs? uppers and workdir too. I'd make this: "ovl: Reject mounting over case-insensitive filesystems" > >> + /* >> + * Root dentries of case-insensitive filesystems might not have >> + * the dentry operations set, but still be incompatible with >> + * overlayfs. Check explicitly to prevent post-mount failures. >> + */ >> + if (sb_has_encoding(path->mnt->mnt_sb)) >> + return invalfc(fc, "case-insensitive filesystem on %s not supported", name); > > sb_has_encoding() doesn't mean that the filesystem is case-insensitive. It > means that the filesystem supports individual case-insensitive > directories. > > With that in mind, is this code still working as intended? > Yes, it is. In particular, after the rest of the patchset, any dentry will be weird and lookups will throw -EREMOTE. > If so, can you update the comment and error message accordingly? I'm not sure how to change and still make it readable by users. How about: return invalfc(fc, "case-insensitive capable filesystem on %s not supported", name); what do you think? -- Gabriel Krisman Bertazi
