On Mon, Aug 31 2009, Christoph Hellwig wrote: > On Mon, Aug 31, 2009 at 02:14:46PM +0200, Jens Axboe wrote: > > Build on the bdi_writeback support by allowing registration of > > more than 1 flusher thread. File systems can call bdi_add_flusher_task(bdi) > > to add more flusher threads to the device. If they do so, they must also > > provide a super_operations function to return the suitable bdi_writeback > > struct from any given inode. > > Please drop this for now. It adds a lot of unused and untestede code > including a dead on arrival inode operation. OK, will drop the multi thread support, I'll retain the worker items though. > Once we are going to add actual multiple flusher threads we can revise > it. But I don't think for example that the operation in it's current > form makese too much sense - the most logical way to add multiple > flushers per filesystems would be having multiple bdis of some sort. Sure, it was more of a proof-of-concept, since I think it'll be important at higher buffered output rates with a single thread becoming a bottle neck. But I have no issues with dropping it for now, it'll be easy enough to re-introduce. I'll post an updated patch series later tonight/tomorrow with the changes. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
