On Wed 03-01-24 13:54:58, Christian Brauner wrote: > I wanted to see whether we can make struct bdev_handle completely > private to the block layer in the next cycle and unexport low-level > helpers such as bdev_release() - formerly blkdev_put() - completely. > > And afaict, we can actually get that to work. Simply put instead of > doing this bdev_open_by_*() dance where we return a struct block_device > we can just make bdev_file_open_by_*() return a struct file. Opening and > closing a block device from setup_bdev_super() and in all other places > just becomes equivalent to opening and closing a file. So I've checked the patchset (not too carefully) and overall I like the direction. I've commented on the few things I didn't quite understand / like but overall I like this. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
