On Wed, Jan 10, 2024 at 07:01:40PM +0000, David Howells wrote: > Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > > zero = __refcount_dec_and_test(&cache->ref, &ref); > > - trace_fscache_cache(debug_id, ref - 1, where); > > + trace_fscache_cache(cache->debug_id, ref - 1, where); > > You can't do that if !zero. cache may be deallocated between the two lines. Ah... Right. I misread what was going on in the latter part of the function. Sorry, I'll resend. regards, dan carpenter
