Wedson Almeida Filho <wedsonaf@xxxxxxxxx> writes:
[...]
> + unsafe extern "C" fn read_dir_callback(
> + file: *mut bindings::file,
> + ctx_ptr: *mut bindings::dir_context,
> + ) -> core::ffi::c_int {
> + from_result(|| {
> + // SAFETY: The C API guarantees that `file` is valid for read. And since `f_inode` is
> + // immutable, we can read it directly.
Should this be "the pointee of `f_inode` is immutable" instead?
[...]
> + pub fn emit(&mut self, pos_inc: i64, name: &[u8], ino: Ino, etype: DirEntryType) -> bool {
> + let Ok(name_len) = i32::try_from(name.len()) else {
> + return false;
> + };
> +
> + let Some(actor) = self.0.actor else {
> + return false;
> + };
> +
> + let Some(new_pos) = self.0.pos.checked_add(pos_inc) else {
> + return false;
> + };
> +
> + // SAFETY: `name` is valid at least for the duration of the `actor` call.
> + let ret = unsafe {
> + actor(
> + &mut self.0,
> + name.as_ptr().cast(),
> + name_len,
> + self.0.pos,
> + ino,
> + etype as _,
I would prefer an explicit target type here.
BR Andreas
