On 12/21/23 12:14, Amir Goldstein wrote:
I think that between you and I, fuse_io_mode is getting very close to
converging, so queuing it for 6.8 really depends on Miklos' availability
during the following week.
I suggest that you incorporate my review comments from github
and/or use the patches that I pushed to my fuse_io_mode branch
and post the io mode patches for review on the list as soon as
possible. I could do that, but I trust that you are testing dio much
better than I am.
Sure, will do that, but I will back out
FOPEN_DIRECT_IO/O_DIRECT-are-the-same in fuse_file_mmap. I don't think
it is needed without parallel mmap and I think it deserves its own
discussion first.
From my point my dio-v5 branch is also ready, it relies on these
patches. Not sure how to post it with the dependency.
Basically, you just post the io mode patch set and then you
post the dio patches with a reference to the io mode patches
that they depend on.
I also have no issue to wait for 6.9, for now I'm going to take these
patches to our fuse module for ubuntu and rhel9 kernels (quite heavily
patched, as it needs to live aside the kernel included module - symbol
renames, etc).
Feels to me like the dio patches are a bit heavier to review than just the
io mode patches, so not likely to be ready for 6.8, but it's not up to me.
I can only say that my review of io mode patches is done and that I have
tested them, while my own ability to review fuse-dio patches for the 6.8
timeframe is limited.
I'm first going to post the fuse_io_mode branch, no need to add in more
distraction. Once Miklos has reviewed (and merged that), I can
immediately post the dio branch.
Thanks,
Bernd
