On Thu, Dec 14, 2023 at 07:01:25PM +0000, Matthew Wilcox wrote: > Was there a reason you only did this for hfs_aops and not for > hfs_btree_aops? It feels like anything that just calls > block_write_full_page() in the writepage handler should be converted > to just calling mpage_writepages() in the writepages handler. > I have a few of those conversions done, but obviously they're in > filesystems that are basically untestable. Probably. I remember I had a good reason to skip, and the lack of testability might have been it. Note that for hfsplus in particular we should actually be able to test now that the port of the hfs userspace has returned to distros. I haven't actually gotten to see what the test baseline looks like, though.
