On Thu, Dec 14, 2023 at 02:50:07PM +0800, kernel test robot wrote: > Hi Al, > > FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git headers.unaligned > head: 959598f725aa7721a4bad53c2e997c7255ff32dc > commit: 959598f725aa7721a4bad53c2e997c7255ff32dc [2/2] move asm/unaligned.h to linux/unaligned.h > config: i386-buildonly-randconfig-002-20231214 (https://download.01.org/0day-ci/archive/20231214/202312141458.agmsUCZB-lkp@xxxxxxxxx/config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231214/202312141458.agmsUCZB-lkp@xxxxxxxxx/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > | Closes: https://lore.kernel.org/oe-kbuild-all/202312141458.agmsUCZB-lkp@xxxxxxxxx/ > > All errors (new ones prefixed by >>): > > In file included from drivers/cxl/core/pci.c:13: > >> drivers/cxl/core/trace.h:11:10: fatal error: asm-generic/unaligned.h: No such file or directory > 11 | #include <asm-generic/unaligned.h> > | ^~~~~~~~~~~~~~~~~~~~~~~~~ Charming... Anything of that sort deserves to be hunted down and shot - including gems like this: net/sunrpc/xprtrdma/verbs.c:58:#include <asm-generic/barrier.h> OK, I'll adjust the script, but IMO we should make it a matter of policy - *NOTHING* outside of arch/ and include/ should ever have #include <asm-generic/whatever.h> #include <asm/something.h> is generally best avoided, but it is defendable; asm-generic is not.
