Re: [PATCH v2 04/16] fs: Increase fmode_t size

To: Christoph Hellwig <hch@xxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>
Subject: Re: [PATCH v2 04/16] fs: Increase fmode_t size
From: John Garry <john.g.garry@xxxxxxxxxx>
Date: Thu, 14 Dec 2023 08:56:08 +0000
Cc: axboe@xxxxxxxxx, kbusch@xxxxxxxxxx, sagi@xxxxxxxxxxx, jejb@xxxxxxxxxxxxx, martin.petersen@xxxxxxxxxx, djwong@xxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, dchinner@xxxxxxxxxx, jack@xxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, tytso@xxxxxxx, jbongio@xxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, ming.lei@xxxxxxxxxx, jaswin@xxxxxxxxxxxxx, bvanassche@xxxxxxx
In-reply-to: <20231213160357.GA9804@lst.de>
Organization: Oracle Corporation
User-agent: Mozilla Thunderbird

But even without that do we even need to increase it?  There's
still quite a lot of space after FMODE_EXEC for example.

Right, I can use the space after FMODE_EXEC, which came free afterremoval of FMODE_NDELAY, FMODE_EXCL, and FMODE_WRITE_IOCTL in v6.5.


Thanks,
John

References:
- [PATCH v2 00/16] block atomic writes
  - From: John Garry
- [PATCH v2 04/16] fs: Increase fmode_t size
  - From: John Garry
- Re: [PATCH v2 04/16] fs: Increase fmode_t size
  - From: Christian Brauner
- Re: [PATCH v2 04/16] fs: Increase fmode_t size
  - From: Christoph Hellwig