On Thu, Dec 07, 2023 at 01:22:03PM +0000, Matthew Wilcox wrote: > On Wed, Dec 06, 2023 at 09:24:03PM -0800, Christoph Hellwig wrote: > > On Wed, Dec 06, 2023 at 08:46:29PM +0000, Matthew Wilcox (Oracle) wrote: > > > Use folio_fill_tail() and folio_end_read() instead of open-coding them. > > > Add a sanity check in case a folio is allocated above index 0. > > > > Where do these helpers come from? Can't find them in Linus' tree. > > Is your tree out of date? > > 0b237047d5a7 for folio_end_read() > $ git describe --contains 0b237047d5a7 > v6.7-rc1~90^2~161 > > folio_fill_tail() appears to only be in akpm's tree for now. Looks like > it's still in the 'unstable' part for now, so no sha1 for that. Heh, I only looked for the first one. But adding what tree you're sending a patch against not only makes reviewing possible, but also helps with the destination.