On Sun 10-12-23 16:18:58, Amir Goldstein wrote: > generic_copy_file_range() is just a wrapper around splice_file_range(), > which caps the maximum copy length. > > The only caller of splice_file_range(), namely __ceph_copy_file_range() > is already ready to cope with short copy. > > Move the length capping into splice_file_range() and replace the exported > symbol generic_copy_file_range() with a simple inline helper. > > Suggested-by: Christoph Hellwig <hch@xxxxxx> > Link: https://lore.kernel.org/linux-fsdevel/20231204083849.GC32438@xxxxxx/ > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> Looks good. Feel free to add: Reviewed-by: Jan Kara <jack@xxxxxxx> Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
