On 12/6/23 12:59, Alice Ryhl wrote:
> + /// Returns the given task's pid in the current pid namespace.
> + pub fn pid_in_current_ns(&self) -> Pid {
> + // SAFETY: Calling `task_active_pid_ns` with the current task is always safe.
> + let namespace = unsafe { bindings::task_active_pid_ns(bindings::get_current()) };
Why not create a safe wrapper for `bindings::get_current()`?
This patch series has three occurrences of `get_current`, so I think it
should be ok to add a wrapper.
I would also prefer to move the call to `bindings::get_current()` out of
the `unsafe` block.
> + // SAFETY: We know that `self.0.get()` is valid by the type invariant.
What about `namespace`?
--
Cheers,
Benno
> + unsafe { bindings::task_tgid_nr_ns(self.0.get(), namespace) }
> + }
