in the process of writing a newbie article on how to use the seq_file implementation of proc files, and i noticed that, in fs/seq_file.c, mangle_path() is EXPORTed, as is seq_path(), but neither of seq_path_root() or seq_dentry(). that just seems slightly inconsistent. is there any value (or obvious drawback) to EXPORTing those other two? rday p.s. LDD3 writes of seq_path(): "It is unlikely to be used in device drivers: we have included it here for completeness." it is invoked exactly once in the source tree, in drivers/md/md.c. just an observation. -- ======================================================================== Robert P. J. Day Waterloo, Ontario, CANADA Linux Consulting, Training and Annoying Kernel Pedantry. Web page: http://crashcourse.ca Twitter: http://twitter.com/rpjday ======================================================================== -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html