On Wed, Nov 22, 2023 at 06:28:14PM -0500, Kent Overstreet wrote: > /** > * bio_for_each_folio_all - Iterate over each folio in a bio. > - * @fi: struct folio_iter which is updated for each folio. > + * @fi: struct bio_folio_iter_all which is updated for each folio. > * @bio: struct bio to iterate over. > */ > -#define bio_for_each_folio_all(fi, bio) \ > - for (bio_first_folio(&fi, bio, 0); fi.folio; bio_next_folio(&fi, bio)) > +#define bio_for_each_folio_all(fv, bio, iter) \ That @fi should be an @fv, no? Does kernel-doc not warn about this mismatch?