On 12/6/23 2:34 PM, Kent Overstreet wrote: > On Wed, Nov 22, 2023 at 06:28:13PM -0500, Kent Overstreet wrote: >> This patch reworks bio_for_each_segment_all() to be more inline with how >> the other bio iterators work: >> >> - bio_iter_all_peek() now returns a synthesized bio_vec; we don't stash >> one in the iterator and pass a pointer to it - bad. This way makes it >> clearer what's a constructed value vs. a reference to something >> pre-existing, and it also will help with cleaning up and >> consolidating code with bio_for_each_folio_all(). >> >> - We now provide bio_for_each_segment_all_continue(), for squashfs: >> this makes their code clearer. > > Jens, can we _please_ get this series merged so bcachefs isn't reaching > into bio/bvec internals? Haven't gotten around to review it fully yet, and nobody else has either fwiw. Would be nice with some reviews. -- Jens Axboe
