On Fri, Aug 07, 2009 at 02:57:38PM -0400, Jeff Layton wrote: > This patch is a counterpart to the CIFS patch posted yesterday. I > believe either patch will fix the problem seen in do_sendfile since the > smaller s_maxbytes value for the two superblocks is used there. This refers to the 'yesterday' 2-3 weeks ago, no? :-) > get_sb_pseudo sets s_maxbytes to ~0ULL, which becomes negative when cast > to a signed value. Fix it to use MAX_LFS_FILESIZE which casts properly > to a positive signed value. I think the proper term is 'converted' in this case, not 'cast'. Even without casts it gets converted by arithmetic operands. > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx> Reviewed-by: Johannes Weiner <hannes@xxxxxxxxxxx> > --- > fs/libfs.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/libfs.c b/fs/libfs.c > index ddfa899..dcec3d3 100644 > --- a/fs/libfs.c > +++ b/fs/libfs.c > @@ -217,7 +217,7 @@ int get_sb_pseudo(struct file_system_type *fs_type, char *name, > return PTR_ERR(s); > > s->s_flags = MS_NOUSER; > - s->s_maxbytes = ~0ULL; > + s->s_maxbytes = MAX_LFS_FILESIZE; > s->s_blocksize = PAGE_SIZE; > s->s_blocksize_bits = PAGE_SHIFT; > s->s_magic = magic; > -- > 1.6.0.6 -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
