Hi Luis, Joel, On 2023-12-05 09:04:08+0100, Thomas Weißschuh wrote: > On 2023-12-04 21:50:14-0800, Luis Chamberlain wrote: > > On Mon, Dec 04, 2023 at 08:52:13AM +0100, Thomas Weißschuh wrote: > > > Tested by booting and with the sysctl selftests on x86. > > > > Can I trouble you to rebase on sysctl-next? > > > > https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=sysctl-next > > Will do. The rebased series is now available at https://git.sr.ht/~t-8ch/linux b4/const-sysctl Nothing much has changed in contrast to v2. The only functional change so far is the initialization of ctl_table_header::type in init_header(). I'll wait for Joels and maybe some more reviews before resending it. > [..] For the future I think it would make sense to combine the tree-wide constification of the structs with the removal of the sentinel values. This would reduce the impacts of the maintainers. Thomas