On Mon, Dec 04, 2023 at 03:19:26PM +0200, Amir Goldstein wrote: > I tried very hard in this series to add a little bit of consistency > for function names and indication of what it may be responsible for. > > After this cleanup series, many of the file permission hooks and > moved from do_XXX() helpers to vfs_XXX() helpers, so I cannot in > good conscience rename do_splice_direct(), which does not have > file permission hooks to vfs_splice_direct(). > > I can rename it to splice_direct() as several other splice_XXX() > exported helpers in this file. Let's keep the name for now. do_ prefixes are not great, especially for exported functions, but no prefix at all isn't great either. So let's get your work done and then we can look into introducing a consistent naming scheme eventually.
