On Thu, 6 Aug 2009 23:26:55 -0700 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > On Thu, 6 Aug 2009 23:12:17 -0700 Mandeep Singh Baines <msb@xxxxxxxxxx> wrote: > > > Christoph Hellwig (hch@xxxxxxxxxxxxx) wrote: > > > On Thu, Aug 06, 2009 at 07:25:56PM -0400, Robert Love wrote: > > > > On Thu, Aug 6, 2009 at 7:24 PM, Christoph Hellwig<hch@xxxxxxxxxxxxx> wrote: > > > > > > > > > The right fix is to not set s_maxbytes to ~0ULL. ?Jeff Layton has sent > > > > > some patches for that recently. > > > > > > > > Yeah, found it here: > > > > http://lkml.org/lkml/2009/7/22/178 > > > > > > I agree. > > > > > > > > I still think this check is worthwhile, given the signed/unsigned mismatch. > > > > > > I think the plan is to change s_maxbytes to be an loff_t which would > > > eliminate this. I'm not sure if Jeff has sent that patch already. > > > > > > > Yeah, found the discussion here: > > > > http://lkml.org/lkml/2009/7/22/241 > > > > Cool. Didn't really like this check. It would be nice to remove the check > > and comment from the next version of this patch. > > Jeff, can you please redo/refresh/review/resend that stuff? > Yep. I'll try to have something next week. The tricky part here is checking all of the existing filesystems and making sure that changing s_maxbytes to loff_t won't break anything. I also want to clean up the checks in do_sendfile like Johannes suggested, though I still have some questions about that... -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
