On Fri, Dec 01, 2023 at 08:37:30AM +0900, Linus Torvalds wrote: > On Thu, 30 Nov 2023 at 21:49, Christian Brauner <brauner@xxxxxxxxxx> wrote: > > > > The naming is actively misleading since we switched to > > SLAB_TYPESAFE_BY_RCU. rcu_head is #define callback_head. Use > > callback_head directly and rename f_rcuhead to f_tw. > > Please just write it out, ie "f_taskwork" or something. Using random > letter combinations is very illegible. It may make sense at the time > (when you are literally editing a line about "init_task_work()") but > it's literally just line noise in that structure definition that makes > me go "f_tw is wtf backwards, wtf?". Oh, I didn't even think about this. > It might even be a good idea to say *what* it is a task work for. Ok, I've added a comment about for both f_llist and f_task_work.
