On 11/30/23 5:49 AM, Christian Brauner wrote: > Only io_uring uses __close_fd_get_file(). All it does is hide > current->files but io_uring accesses files_struct directly right now > anyway so it's a bit pointless. Just rename pick_file() to > file_close_fd_locked() and let io_uring use it. Add a lockdep assert in > there that we expect the caller to hold file_lock while we're at it. LGTM. Reviewed-by: Jens Axboe <axboe@xxxxxxxxx> -- Jens Axboe