On Mon, Nov 27, 2023 at 8:05 AM Christian Brauner <brauner@xxxxxxxxxx> wrote:
>
> > + if (path.mnt->mnt_root != path.dentry) {
>
> You want to verify that you can only create tokens from the root of the
> bpffs mount. So for
>
> sudo mount -t bpf bpf /mnt
>
> you want bpf tokens to be creatable from:
>
> fd = open("/mnt")
>
> or from bind-mounts of the fs root:
>
> sudo mount --bind /mnt /srv
> fd = open("/srv")
>
> but not from
>
> sudo mount --bind /mnt/foo /opt
> fd = open("/opt")
>
> But I think your current check allows for that because if you bind-mount
> /mnt/foo to /opt then fd = open("/opt")
>
> path.mnt->mnt_root == foo and path.dentry == foo
>
> I think
>
> path.dentry != path.mnt->mnt_sb->s_root
>
> should give you what you want.
Ah, subtle difference (for me :)). Yes, I'd like the actual root of
bpffs to be used, will adjust the check, thanks!
